lucasbru commented on code in PR #20944:
URL: https://github.com/apache/kafka/pull/20944#discussion_r2560031613
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -4599,28 +4615,43 @@ public void
shouldNotFailForTimeoutExceptionOnConsumerCommit() {
verify(consumer, times(2)).commitSync(any(Map.class));
}
+ @SuppressWarnings("removal")
Review Comment:
Why did we have to add this? Maybe add a comment.
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -3374,33 +3352,41 @@ public void
shouldCloseActiveTasksAndPropagateStreamsProducerExceptionsOnCleanSh
@Test
public void
shouldOnlyCommitRevokedStandbyTaskAndPropagatePrepareCommitException() {
Review Comment:
The method name says "prepare commit exception" but then we throw in
`suspend`. Is this intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
