mjsax commented on code in PR #20972:
URL: https://github.com/apache/kafka/pull/20972#discussion_r2558459283


##########
tests/kafkatest/version.py:
##########
@@ -248,4 +248,5 @@ def get_version(node=None):
 
 # 4.2.x version
 V_4_2_0 = KafkaVersion("4.2.0")
-LATEST_4_2 = V_4_2_0
+V_4_2_1 = KafkaVersion("4.2.1")
+LATEST_4_2 = V_4_2_1

Review Comment:
   I see. Thanks for clarifying. Guess, for `4.2` branch we don't really use 
`LATEST_4_2` anywhere else, so it might be fine. And the test code you refer to 
uses `V_4_2_0` explicitly.
   
   Bottom line: I understand why we needed to add `V_4_2_0`, but both 
`LATEST_4_2` and `V_4_2_1` seem not to be necessary for `4.2` branch, and 
especially pointing `LATEST_4_2` to an unreleased version seems odd (even if it 
does not break anything as it's unused).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to