[ 
https://issues.apache.org/jira/browse/KAFKA-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040092#comment-18040092
 ] 

Ibuki Kaji commented on KAFKA-19097:
------------------------------------

Hi [~ksolves.kafka] 

Thank you very much for your PRs and for working on this ticket.
While looking at the changes, I noticed a few remaining places that seem to be 
related to this ticket but are not yet updated in past PRs.

Would it be okay if I open an additional PR to address those parts as well?
Thanks in advance, and please let me know if you have any concerns.

> Fix order of arguments to assertEquals
> --------------------------------------
>
>                 Key: KAFKA-19097
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19097
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, unit tests
>            Reporter: Lorcan
>            Assignee: Ksolves India Limited
>            Priority: Minor
>              Labels: beginner-friendly, newbie,
>
> There are examples of tests using assertEquals where the arguments are in the 
> wrong order.
> Example from InternalStreamsBuilderTest:
> assertEquals(count.get(), 3);
> The expected value should be the first argument.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to