izzyharker commented on code in PR #20907:
URL: https://github.com/apache/kafka/pull/20907#discussion_r2543032165
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroup.java:
##########
@@ -147,6 +149,29 @@ public String toLowerCaseString() {
private final TimelineObject<Boolean> hasSubscriptionMetadataRecord;
+ private final LogContext logContext;
+
+ private final Logger log;
+
+ public ConsumerGroup(
+ LogContext logContext,
+ SnapshotRegistry snapshotRegistry,
+ String groupId
+ ) {
Review Comment:
I think the second constructor can just call the first unless it really
needs to be removed? That way it's still not as redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
