dajac commented on code in PR #20904:
URL: https://github.com/apache/kafka/pull/20904#discussion_r2536672883
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2437,6 +2438,16 @@ private CoordinatorResult<Void, CoordinatorRecord>
classicGroupJoinToConsumerGro
records
);
+ bumpGroupEpoch |= maybeUpdateRegularExpressions(
+ context,
+ group,
+ member,
+ updatedMember,
+ records
+ );
+
+ bumpGroupEpoch |=
!member.subscribedTopicRegex().equals(updatedMember.subscribedTopicRegex());
Review Comment:
Could we put a comment to explain the rational of this one? I also wonder
whether we could just check that the previous one was non-empty as it is a
simple check. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
