gaurav-narula commented on code in PR #20141:
URL: https://github.com/apache/kafka/pull/20141#discussion_r2515543274
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1109,10 +1109,12 @@ class ReplicaManager(val config: KafkaConfig,
} catch {
case e@ (_: UnknownTopicOrPartitionException |
_: NotLeaderOrFollowerException |
- _: OffsetOutOfRangeException |
_: PolicyViolationException |
_: KafkaStorageException) =>
(topicPartition, LogDeleteRecordsResult(-1L, -1L, Some(e)))
+ case e: OffsetOutOfRangeException =>
+ debug("Error processing delete records operation on partition %s.
%s".format(topicPartition, e.getMessage))
Review Comment:
It's very well a personal preference but I always prefer to have the
stacktrace. The message might tell you the "why" but I've found the "where/how"
to be immensely useful when debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
