chia7712 commented on code in PR #20783: URL: https://github.com/apache/kafka/pull/20783#discussion_r2480571901
########## metadata/src/main/java/org/apache/kafka/metadata/publisher/DynamicTopicClusterQuotaPublisher.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.metadata.publisher; + +import org.apache.kafka.common.Cluster; +import org.apache.kafka.image.MetadataDelta; +import org.apache.kafka.image.MetadataImage; +import org.apache.kafka.image.loader.LoaderManifest; +import org.apache.kafka.image.publisher.MetadataPublisher; +import org.apache.kafka.metadata.MetadataCache; +import org.apache.kafka.server.fault.FaultHandler; + +public class DynamicTopicClusterQuotaPublisher implements MetadataPublisher { + private final String clusterId; + private final int nodeId; + private final FaultHandler faultHandler; + private final String nodeType; + private final QuotaManagersProvider quotaManagersProvider; + + public DynamicTopicClusterQuotaPublisher( + String clusterId, + int nodeId, + FaultHandler faultHandler, + String nodeType, + QuotaManagersProvider quotaManagers Review Comment: Could you consider de-coupling those components by using lambda function? for example: ```java public DynamicTopicClusterQuotaPublisher( String clusterId, int nodeId, FaultHandler faultHandler, String nodeType, Plugin<ClientQuotaCallback> clientQuotaCallbackPlugin, Runnable updateQuotaMetricConfigs ) { this.clusterId = clusterId; this.nodeId = nodeId; this.faultHandler = faultHandler; this.nodeType = nodeType; this.clientQuotaCallbackPlugin = clientQuotaCallbackPlugin; this.updateQuotaMetricConfigs = updateQuotaMetricConfigs; } @Override public String name() { return "DynamicTopicClusterQuotaPublisher " + nodeType + " id=" + nodeId; } @Override public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage, LoaderManifest manifest) { try { if (delta.topicsDelta() != null || delta.clusterDelta() != null) { Cluster cluster = MetadataCache.toCluster(clusterId, newImage); if (clientQuotaCallbackPlugin.get().updateClusterMetadata(cluster)) { updateQuotaMetricConfigs.run(); } } } catch (Exception e) { String deltaName = "MetadataDelta up to " + newImage.highestOffsetAndEpoch().offset(); faultHandler.handleFault("Uncaught exception while publishing dynamic topic or cluster changes from " + deltaName, e); } } ``` 1. we could create `DynamicTopicClusterQuotaPublisher` only if the `clientQuotaCallbackPlugin` is existent 2. we wrap all callbacks in a single runnable object to avoid move many classes into `server-common` module @JimmyWang6 WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
