AndrewJSchofield commented on code in PR #20246:
URL: https://github.com/apache/kafka/pull/20246#discussion_r2471466258
##########
server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java:
##########
@@ -50,6 +50,7 @@ public class ShareFetchTest {
private static final String GROUP_ID = "groupId";
private static final String MEMBER_ID = "memberId";
+ private static final byte SHARE_ACQUIRE_MODE = 0;
Review Comment:
This is the id for `BATCH_OPTIMIZED`. I would prefer to see
`BATCH_OPTIMIZED` used as the parameter rather than `SHARE_ACQUIRE_MODE`.
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -5929,6 +5929,7 @@ class ReplicaManagerTest {
Uuid.randomUuid.toString,
future,
topicPartitions,
+ 0,
Review Comment:
This is `ShareAcquireMode.BATCH_OPTIMIZED.id()` or similar I think. We
should have a consistent way of referring to this constant in the broker code
and tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
