chia7712 commented on code in PR #20740:
URL: https://github.com/apache/kafka/pull/20740#discussion_r2449071179
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##########
@@ -1364,6 +1364,7 @@ private AnalyzeAndValidateProducerStateResult
analyzeAndValidateProducerState(Lo
Optional<BatchMetadata> duplicateBatch =
maybeLastEntry.flatMap(e -> e.findDuplicateBatch(batch));
if (duplicateBatch.isPresent()) {
+ logger.info("Found duplicate batch from client,
duplicateBatchMetadata={}", duplicateBatch.get());
Review Comment:
Perhaps we should move the log statement to `UnifiedLog#append`. Since
another branch already has the log `logger.trace("Appended message set with
...`, it would be straightforward to add a similar log for duplicate batches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
