see-quick commented on code in PR #20546:
URL: https://github.com/apache/kafka/pull/20546#discussion_r2371671677
##########
tests/docker/run_tests.sh:
##########
@@ -20,6 +20,15 @@ KAFKA_NUM_CONTAINERS=${KAFKA_NUM_CONTAINERS:-14}
TC_PATHS=${TC_PATHS:-./kafkatest/}
REBUILD=${REBUILD:f}
+# Auto-detect container runtime if not set
+if [[ -z "${CONTAINER_RUNTIME}" ]]; then
Review Comment:
Hmm, so what if we add a fallback to `docker' in the else branch?
```
if [[ -z "${CONTAINER_RUNTIME}" ]]; then
if command -v docker &> /dev/null; then
export CONTAINER_RUNTIME="docker"
elif command -v podman &> /dev/null; then
export CONTAINER_RUNTIME="podman"
else
export CONTAINER_RUNTIME="docker"
fi
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
