Yunyung commented on code in PR #20366:
URL: https://github.com/apache/kafka/pull/20366#discussion_r2345780146
##########
core/src/main/scala/kafka/raft/KafkaRaftManager.scala:
##########
@@ -292,12 +260,8 @@ class KafkaRaftManager[T](
(controllerListenerName, networkClient)
}
- override def leaderAndEpoch: LeaderAndEpoch = {
- client.leaderAndEpoch
- }
-
- override def voterNode(id: Int, listener: ListenerName): Option[Node] = {
- client.voterNode(id, listener).toScala
+ override def voterNode(id: Int, listener: ListenerName): Optional[Node] = {
+ client.voterNode(id, listener)
Review Comment:
Updated. Since `voterNode` is not part of the `RaftClient` interface, we
need to add this method to the interface, PTAL.
I missed this comment earlier, sorry for the late response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
