chia7712 commented on code in PR #20068:
URL: https://github.com/apache/kafka/pull/20068#discussion_r2344052086
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -3093,6 +3107,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
TestUtils.assertLeader(client, partition2, 0)
// Now change the preferred leader to 1
+ waitForBrokerMetadataPropagation(partition1);
Review Comment:
not sure why we check only `partition1`? the method `changePreferredLeader`
could impact both partitions, right?
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -3147,9 +3164,12 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
TestUtils.assertLeader(client, partition2, 2)
// Now change the preferred leader to 1
+ waitForBrokerMetadataPropagation(partition1)
+ waitForBrokerMetadataPropagation(partition2)
changePreferredLeader(prefer1)
// but shut it down...
killBroker(1)
+ waitForBrokerMetadataPropagation(partition1)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
