appchemist commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2328735171


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GraphNode.java:
##########
@@ -93,6 +99,23 @@ public String nodeName() {
         return nodeName;
     }
 
+    public boolean canDetermineRepartition() {
+        return keyChangingOperation || repartitionForbidden || 
repartitionRequired;
+    }
+
+    public boolean isRepartitionRequired() {
+        final GraphNode find = 
findNearestParentNodeMatching(GraphNode::canDetermineRepartition);

Review Comment:
   @mjsax When deciding whether to repartition, 
   I modified it because the BFS approach seemed more suitable than the 
existing DFS method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to