chia7712 commented on code in PR #20471:
URL: https://github.com/apache/kafka/pull/20471#discussion_r2319940997
##########
tests/kafkatest/services/verifiable_producer.py:
##########
@@ -249,7 +249,14 @@ def start_cmd(self, node, idx):
if self.repeating_keys is not None:
cmd += " --repeating-keys %s " % str(self.repeating_keys)
- cmd += " --command-config %s" % VerifiableProducer.CONFIG_FILE
+ # According to KIP-1147, --producer.config has been deprecated and
will be removed in future versions.
+ # For backward compatibility, we select the configuration based on
node version:
+ # - For versions 4.2.0 and above, use --command-config
+ # - For older versions, continue using --producer.config
+ if node.version >= V_4_2_0:
Review Comment:
Could you please consider adding a helper method to `KafkaVersion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
