mjsax commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319982525
##########
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##########
@@ -86,6 +87,28 @@
*/
@SuppressWarnings("deprecation")
public final class TopologyConfig extends AbstractConfig {
+
+ public static class InternalConfig {
+ // Cf https://issues.apache.org/jira/browse/KAFKA-19668
+ public static final String DISABLE_PROCESS_PROCESSVALUE_FIX =
"__disable.process.processValue.fix__";
+
+ public static boolean getBoolean(final Map<String, Object> configs,
final String key, final boolean defaultValue) {
+ final Object value = configs.getOrDefault(key, defaultValue);
+ if (value instanceof Boolean) {
+ return (boolean) value;
Review Comment:
Yes, because the type of `value` is `Object`. We could also cast to
`Boolean`. So some auto-conversion/unboxing happens anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
