ahuang98 commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2319808559
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -549,6 +550,7 @@ private Throwable handleEventException(
} else {
deltaUs = OptionalLong.empty();
}
+ controllerMetrics.updateIdleStartTime();
Review Comment:
feels almost like updateIdleStartTime should be tied to/incorporated into
updateEventQueueProcessingTime
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -831,6 +834,7 @@ public void run() throws Exception {
// Remember the latest offset and future if it is not already
completed
if (!future.isDone()) {
+ controllerMetrics.updateIdleStartTime();
Review Comment:
I see, this covers when future is not completed, the addition in complete()
covers when the future _is_ completed, and the corresponding call to
updateIdleEndTime was added to updateEventStartMetricsAndGetTime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
