Yunyung commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319771084
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##########
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefault("")
.type(String.class)
.dest("offsetResetStrategy")
- .help("Set share group reset strategy (must be either 'earliest'
or 'latest')");
+ .metavar("OFFSET-RESET-STRATEGY")
+ .help("Share group offset reset strategy (must be either
'earliest' or 'latest')");
parser.addArgument("--command-config")
.action(store())
.required(false)
.type(String.class)
.dest("commandConfig")
- .metavar("CONFIG_FILE")
+ .metavar("CONFIG-FILE")
Review Comment:
Yes, this is a bit annoying. If we have to choose between the two, we should
probably use joptsimple everywhere, since most scripts already rely on
CommandDefaultOptions, which works well with CommandLineUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
