shashankhs11 commented on code in PR #20462:
URL: https://github.com/apache/kafka/pull/20462#discussion_r2318872382
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##########
@@ -303,16 +304,15 @@ public void shouldPassMetrics(final String topologyType,
final boolean stateUpda
}
}
- @ParameterizedTest
- @MethodSource("multiTaskParameters")
- public void shouldPassCorrectMetricsDynamicInstances(final boolean
stateUpdaterEnabled, final String groupProtocol) throws Exception {
+ @Test
+ public void shouldPassCorrectMetricsDynamicInstances() throws Exception {
// Correct streams metrics should get passed with dynamic membership
- streamsApplicationProperties = props(stateUpdaterEnabled,
groupProtocol);
+ streamsApplicationProperties = props("classic");
streamsApplicationProperties.put(StreamsConfig.STATE_DIR_CONFIG,
TestUtils.tempDirectory(appId).getPath() + "-ks1");
streamsApplicationProperties.put(StreamsConfig.CLIENT_ID_CONFIG, appId
+ "-ks1");
- streamsSecondApplicationProperties = props(stateUpdaterEnabled,
groupProtocol);
+ streamsSecondApplicationProperties = props("classic");
Review Comment:
I see that this was disabled recently in #20147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
