kuoche1712003 commented on code in PR #20399:
URL: https://github.com/apache/kafka/pull/20399#discussion_r2318536120
##########
core/src/main/scala/kafka/server/AbstractFetcherManager.scala:
##########
@@ -30,7 +30,9 @@ import scala.jdk.OptionConverters._
abstract class AbstractFetcherManager[T <: AbstractFetcherThread](val name:
String, clientId: String, numFetchers: Int)
extends Logging {
- private val metricsGroup = new KafkaMetricsGroup(this.getClass)
+ private val metricsPackage = "kafka.server"
+ private val metricsClassName = "AbstractFetcherManager"
+ private val metricsGroup = new KafkaMetricsGroup(metricsPackage,
metricsClassName)
Review Comment:
Hardcoding the metricsClassName for AbstractFetcherManager.
I want to make sure this approach won't introduce any unexpected side
effects or break existing functionality.
ex. ReplicaAlterLogDirsManager and ReplicaFetcherManager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
