chia7712 commented on code in PR #20414:
URL: https://github.com/apache/kafka/pull/20414#discussion_r2309740081
##########
server/src/main/java/org/apache/kafka/server/config/ReplicationConfigs.java:
##########
@@ -147,7 +147,7 @@ public class ReplicationConfigs {
.define(REPLICA_FETCH_BACKOFF_MS_CONFIG, INT,
REPLICA_FETCH_BACKOFF_MS_DEFAULT, atLeast(0), MEDIUM,
REPLICA_FETCH_BACKOFF_MS_DOC)
.define(REPLICA_FETCH_MIN_BYTES_CONFIG, INT,
REPLICA_FETCH_MIN_BYTES_DEFAULT, HIGH, REPLICA_FETCH_MIN_BYTES_DOC)
.define(REPLICA_FETCH_RESPONSE_MAX_BYTES_CONFIG, INT,
REPLICA_FETCH_RESPONSE_MAX_BYTES_DEFAULT, atLeast(0), MEDIUM,
REPLICA_FETCH_RESPONSE_MAX_BYTES_DOC)
- .define(NUM_REPLICA_FETCHERS_CONFIG, INT,
NUM_REPLICA_FETCHERS_DEFAULT, HIGH, NUM_REPLICA_FETCHERS_DOC)
+ .define(NUM_REPLICA_FETCHERS_CONFIG, INT,
NUM_REPLICA_FETCHERS_DEFAULT, atLeast(1), HIGH, NUM_REPLICA_FETCHERS_DOC)
Review Comment:
`-1` is weird but it actually works. Perhaps it requires a KIP to follow our
compatibility policy. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
