aheev commented on PR #20256: URL: https://github.com/apache/kafka/pull/20256#issuecomment-3229075386
> Thanks for the patch! > > > Since metadataCache is [first updated](https://github.com/apache/kafka/blob/f81853ca8858fe1dfbb038ce39c8595a2a42c484/core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala#L132-L150) before ReplicaManager.applyDelta, [stopPartitions](https://github.com/apache/kafka/blob/42644b3045eb0be3d8646496ca43dfaca75b6923/core/src/main/scala/kafka/server/ReplicaManager.scala#L2360), inturn rlm.stopPartitions is not able to [find topicId](https://github.com/aheev/kafka/blob/42644b3045eb0be3d8646496ca43dfaca75b6923/storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java#L506). Why can't we just use TopicIdPartition in [StopPartition](https://github.com/apache/kafka/blob/5d2074e8f26a0573fd7d66cc4dfa68a9dae58dc4/server-common/src/main/java/org/apache/kafka/server/common/StopPartition.java#L26) class > > yeah, I think topicId can be set in the StopPartition object to propagate the value to the RemoteLogManager. The deletedTopicIds is available in the TopicsDelta. Replaced `TopicPartition` with `TopicIdPartition` in `StopPartition` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
