brandboat commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2303419966
########## tools/src/test/java/org/apache/kafka/tools/ConsumerPerformanceTest.java: ########## @@ -136,7 +174,9 @@ public void testConfigWithoutTopicAndInclude() { @Test public void testClientIdOverride() throws IOException { - File tempFile = Files.createFile(tempDir.resolve("test_consumer_config.conf")).toFile(); + Path configPath = tempDir.resolve("test_consumer_config.conf"); + Files.deleteIfExists(configPath); Review Comment: I see, we have multiple test files with the same name. We could give them distinct names—for example, by adding a random suffix or simply choosing different names. This is just my personal nit though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org