Yunyung commented on code in PR #20379:
URL: https://github.com/apache/kafka/pull/20379#discussion_r2288749681


##########
core/src/main/scala/kafka/tools/TestRaftServer.scala:
##########
@@ -428,7 +428,7 @@ object TestRaftServer extends Logging {
   }
 
   private class TestRaftServerOptions(args: Array[String]) extends 
CommandDefaultOptions(args) {
-    val configOpt: OptionSpec[String] = parser.accepts("config", "Required 
configured file")
+    val configOpt: OptionSpec[String] = parser.accepts("config", "REQUIRED: 
The configured file")

Review Comment:
   Updated. Thanks.
   
   ### Verification:
   ```
   $ bin/test-kraft-server-start.sh
   [2025-08-21 00:41:04,035] INFO Registered `kafka:type=kafka.Log4jController` 
MBean (kafka.utils.Log4jControllerRegistration$)
   Standalone raft server for performance testing
   Option                                  Description                          
 
   ------                                  -----------                          
 
   --config <String: filename>             REQUIRED: The configured file        
 
   --help                                  Print usage information.             
 
   --record-size <Integer: size in bytes>  The size of each record (default: 
256)
   --replica-directory-id <String:         REQUIRED: The directory id of the    
 
     directory id>                           replica                            
 
   --throughput <Integer: records/sec>     The number of records per second the 
 
                                             leader will write to the metadata  
 
                                             topic (default: 5000)              
 
   --version                               Display Kafka version.               
 
   ```
   
   ```
   $ bin/test-kraft-server-start.sh --config config/kraft.properties 
   [2025-08-21 00:41:12,627] INFO Registered `kafka:type=kafka.Log4jController` 
MBean (kafka.utils.Log4jControllerRegistration$)
   Missing required argument "[replica-directory-id]"
   Option                                  Description                          
 
   ------                                  -----------                          
 
   --config <String: filename>             REQUIRED: The configured file        
 
   --help                                  Print usage information.             
 
   --record-size <Integer: size in bytes>  The size of each record (default: 
256)
   --replica-directory-id <String:         REQUIRED: The directory id of the    
 
     directory id>                           replica                            
 
   --throughput <Integer: records/sec>     The number of records per second the 
 
                                             leader will write to the metadata  
 
                                             topic (default: 5000)              
 
   --version                               Display Kafka version.               
 
   ```
   
   ```
   $ bin/test-kraft-server-start.sh --replica-directory-id 
b8tRS7h4TJ2Vt43Dp85v2A
   [2025-08-21 00:41:22,486] INFO Registered `kafka:type=kafka.Log4jController` 
MBean (kafka.utils.Log4jControllerRegistration$)
   Missing required argument "[config]"
   Option                                  Description                          
 
   ------                                  -----------                          
 
   --config <String: filename>             REQUIRED: The configured file        
 
   --help                                  Print usage information.             
 
   --record-size <Integer: size in bytes>  The size of each record (default: 
256)
   --replica-directory-id <String:         REQUIRED: The directory id of the    
 
     directory id>                           replica                            
 
   --throughput <Integer: records/sec>     The number of records per second the 
 
                                             leader will write to the metadata  
 
                                             topic (default: 5000)              
 
   --version                               Display Kafka version. 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to