junrao commented on code in PR #20334:
URL: https://github.com/apache/kafka/pull/20334#discussion_r2288732259


##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java:
##########
@@ -61,11 +61,13 @@ public abstract class HeaderFrom<R extends 
ConnectRecord<R>> implements Transfor
 
     public static final ConfigDef CONFIG_DEF = new ConfigDef()
             .define(FIELDS_FIELD, ConfigDef.Type.LIST,
-                    NO_DEFAULT_VALUE, new NonEmptyListValidator(),
+                    NO_DEFAULT_VALUE,
+                    new NonEmptyListValidator(),

Review Comment:
   Thanks for the explanation. Should we update the KIP to allow duplicates for 
HeaderFrom.fields? Also, HeaderFrom.headers shouldn't have duplicated, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to