Yunyung commented on code in PR #20381:
URL: https://github.com/apache/kafka/pull/20381#discussion_r2286870344
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -1036,8 +1048,9 @@ public void testTopicNotExistingInMetadata() throws
InterruptedException {
@Test
public void testTopicExpiryInMetadata() throws InterruptedException {
Map<String, Object> configs = new HashMap<>();
+ final String maxBlockMs = "300000";
Review Comment:
Why did you add an extra zero? Was that intentional?
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -969,20 +970,28 @@ public void testTopicRefreshInMetadata() throws
InterruptedException {
final Time time = new MockTime();
final ProducerMetadata metadata = new
ProducerMetadata(refreshBackoffMs, refreshBackoffMaxMs, metadataExpireMs,
metadataIdleMs,
new LogContext(), new ClusterResourceListeners(), time);
+ final String warmupTopic = "warmup-topic";
Review Comment:
Why do we need a warmupTopic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
