apoorvmittal10 commented on code in PR #20144:
URL: https://github.com/apache/kafka/pull/20144#discussion_r2285727157
##########
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java:
##########
@@ -123,10 +124,36 @@ public void testValidateIntervalMsInvalid(int
pushIntervalMs) {
@Test
public void testPreferredCompressionType() {
- assertEquals(CompressionType.NONE,
ClientTelemetryUtils.preferredCompressionType(Collections.emptyList()));
- assertEquals(CompressionType.NONE,
ClientTelemetryUtils.preferredCompressionType(null));
- assertEquals(CompressionType.NONE,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.NONE,
CompressionType.GZIP)));
- assertEquals(CompressionType.GZIP,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.GZIP,
CompressionType.NONE)));
+ // Test with no unsupported types
+ assertEquals(CompressionType.NONE,
ClientTelemetryUtils.preferredCompressionType(Collections.emptyList(),
Collections.emptySet()));
+ assertEquals(CompressionType.NONE,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.NONE,
CompressionType.GZIP), Collections.emptySet()));
+ assertEquals(CompressionType.GZIP,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.GZIP,
CompressionType.NONE), Collections.emptySet()));
+
+ // Test with unsupported types filtering
+ assertEquals(CompressionType.LZ4,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.GZIP,
CompressionType.LZ4), Set.of(CompressionType.GZIP)));
+ assertEquals(CompressionType.NONE,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.GZIP,
CompressionType.NONE), Set.of(CompressionType.GZIP)));
+ assertEquals(CompressionType.SNAPPY,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.GZIP,
CompressionType.LZ4, CompressionType.SNAPPY), Set.of(CompressionType.GZIP,
CompressionType.LZ4)));
+
+ // Test when all types are unsupported
+ assertEquals(CompressionType.NONE,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.GZIP),
Set.of(CompressionType.GZIP)));
+ assertEquals(CompressionType.NONE,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.GZIP,
CompressionType.LZ4), Set.of(CompressionType.GZIP, CompressionType.LZ4)));
+
+ // Test priority order with unsupported types (first available wins)
+ assertEquals(CompressionType.ZSTD,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.ZSTD,
CompressionType.SNAPPY), Set.of()));
+ assertEquals(CompressionType.SNAPPY,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.ZSTD,
CompressionType.SNAPPY), Set.of(CompressionType.ZSTD)));
+ assertEquals(CompressionType.GZIP,
ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.LZ4,
CompressionType.GZIP, CompressionType.SNAPPY), Set.of(CompressionType.LZ4)));
Review Comment:
How these tests are different than above `// Test with unsupported types
filtering`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
