chia7712 commented on code in PR #20370:
URL: https://github.com/apache/kafka/pull/20370#discussion_r2283406812
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##########
@@ -65,10 +65,8 @@ class TransactionMarkerChannelManagerTest {
private val coordinatorEpoch2 = 1
private val txnTimeoutMs = 0
private val txnResult = TransactionResult.COMMIT
- private val txnMetadata1 = new TransactionMetadata(transactionalId1,
producerId1, producerId1, RecordBatch.NO_PRODUCER_ID,
- producerEpoch, lastProducerEpoch, txnTimeoutMs,
TransactionState.PREPARE_COMMIT, util.Set.of(partition1, partition2), 0L, 0L,
TransactionVersion.TV_2)
- private val txnMetadata2 = new TransactionMetadata(transactionalId2,
producerId2, producerId2, RecordBatch.NO_PRODUCER_ID,
- producerEpoch, lastProducerEpoch, txnTimeoutMs,
TransactionState.PREPARE_COMMIT, util.Set.of(partition1), 0L, 0L,
TransactionVersion.TV_2)
+ private val txnMetadata1 = new TransactionMetadata(transactionalId1,
producerId1, producerId1, RecordBatch.NO_PRODUCER_ID, producerEpoch,
lastProducerEpoch, txnTimeoutMs, TransactionState.PREPARE_COMMIT, 0L, 0L,
TransactionVersion.TV_2)
Review Comment:
it seems those tests assume `txnMetadata1` have some topicPartitions
initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
