chia7712 commented on code in PR #20354:
URL: https://github.com/apache/kafka/pull/20354#discussion_r2278892176


##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -3356,17 +3352,13 @@ private long pollFollowerAsObserver(FollowerState 
state, long currentTimeMs) {
             } else {
                 sendResult = maybeSendAddVoterRequest(state, currentTimeMs);
             }
-            backoffMs = sendResult.timeToWaitMs();
             if (sendResult.requestSent()) {
                 state.resetUpdateVoterSetPeriod(currentTimeMs);
             }
+            return sendResult.timeToWaitMs();

Review Comment:
   What happens if `timeToWaitMs` is larger than the fetch timeout? Could the 
observer miss a fetch request?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to