RaidenE1 commented on code in PR #20325: URL: https://github.com/apache/kafka/pull/20325#discussion_r2270909118
########## core/src/main/scala/kafka/server/AutoTopicCreationManager.scala: ########## @@ -112,6 +128,45 @@ class DefaultAutoTopicCreationManager( } } + override def getTopicCreationErrors( + topicNames: Set[String] + ): Map[String, String] = { + val currentTime = System.currentTimeMillis() + val errors = mutable.Map.empty[String, String] + val expiredKeys = mutable.Set.empty[String] + + // Check requested topics and collect expired keys + topicNames.foreach { topicName => + Option(topicCreationErrorCache.get(topicName)) match { + case Some(cachedError) if (currentTime - cachedError.timestamp) <= errorCacheTtlMs => + errors.put(topicName, cachedError.errorMessage) + case Some(_) => Review Comment: @mjsax The case Some(_) will indeed be executed. In Scala pattern matching: 1. case Some(cachedError) if (condition) only matches when the guard condition is true 2. If the condition is false (TTL expired), it falls through to case Some(_) 3. So we hit the second case when we have a cached error that's expired The pattern matching is sequential with guard conditions, not a "catch all" for the first Some(...). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org