TaiJuWu commented on code in PR #20335:
URL: https://github.com/apache/kafka/pull/20335#discussion_r2267077633
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -800,23 +800,23 @@ class Partition(val topicPartition: TopicPartition,
currentTimeMs,
leaderEpochStartOffset,
isNewLeader,
- partitionState.isr.contains(replica.brokerId)
+ isr.contains(replica.brokerId)
)
}
// We update the leader epoch and the leader epoch start offset iff the
// leader epoch changed.
- leaderEpoch = partitionState.leaderEpoch
+ leaderEpoch = partitionRegistration.leaderEpoch
leaderEpochStartOffsetOpt = Some(leaderEpochStartOffset)
} else {
stateChangeLogger.info(s"Skipped the become-leader state change for
$topicPartition with topic id $topicId " +
- s"and partition state $partitionState since it is already the leader
with leader epoch $leaderEpoch. " +
+ s"and partition state $partitionRegistration since it is already the
leader with leader epoch $leaderEpoch. " +
Review Comment:
Should change to `and partition registeration` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
