showuon commented on code in PR #20306:
URL: https://github.com/apache/kafka/pull/20306#discussion_r2262400531


##########
docs/configuration.html:
##########
@@ -329,8 +329,23 @@ <h4><a 
id="org.apache.kafka.automatic.config.providers"></a><a id="systempropert
   <h3 class="anchor-heading"><a id="tieredstorageconfigs" 
class="anchor-link"></a><a href="#tieredstorageconfigs">3.11 Tiered Storage 
Configs</a></h3>
   Below is the Tiered Storage configuration.
   <!--#include virtual="generated/remote_log_manager_config.html" -->
+
+  <h4 class="anchor-heading"><a id="rlmmconfigs" class="anchor-link"></a><a 
href="#rlmmconfigs">3.11.1 RLMM Configs</a></h4>
+  <p>Below is the configuration for 
<code>TopicBasedRemoteLogMetadataManager</code>, which is the default 
implementation of <code>RemoteLogMetadataManager</code>.</p>
+  <p>All configurations here should start with the prefix defined by 
<code>remote.log.metadata.manager.impl.prefix</code>, for example, 
<code>rlmm.config.remote.log.metadata.consume.wait.ms</code>.</p>
   <!--#include virtual="generated/remote_log_metadata_manager_config.html" -->
 
+  <p>The implementation of <code>TopicBasedRemoteLogMetadataManager</code> 
needs to create admin, producer, and consumer clients for the internal topic 
<code>__remote_log_metadata</code>.</p>
+  <p>Additional configurations can be provided for different types of clients 
using the following configuration properties: </p>
+  <pre><code class="language-text"># Configs for admin, producer, and consumer 
clients
+&lt;rlmm.prefix&gt;.remote.log.metadata.common.client.&lt;kafka.property&gt; = 
&lt;value&gt;
+
+# Configs only for producer client

Review Comment:
   [KAFKA-19590](https://issues.apache.org/jira/browse/KAFKA-19590) is created 
for this improvement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to