chia7712 commented on code in PR #20294:
URL: https://github.com/apache/kafka/pull/20294#discussion_r2250792060
##########
build.gradle:
##########
@@ -37,7 +37,7 @@ plugins {
id 'org.nosphere.apache.rat' version "0.8.1"
id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}"
- id "com.github.spotbugs" version '6.0.25' apply false
+ id "com.github.spotbugs" version '6.2.2' apply false
Review Comment:
the latest version is `6.2.3`. could you please give it a try
##########
gradle/dependencies.gradle:
##########
@@ -123,7 +123,7 @@ versions += [
scoverage: "2.0.11",
slf4j: "1.7.36",
snappy: "1.1.10.7",
- spotbugs: "4.8.6",
+ spotbugs: "4.9.1",
Review Comment:
ditto. If there is a strong reason to use `4.9.1` instead of `4.9.3`, could
you please add comments explaining it?
##########
gradle/spotbugs-exclude.xml:
##########
@@ -550,4 +550,173 @@ For a detailed description of spotbugs bug categories,
see https://spotbugs.read
<Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
</Match>
+ <Match>
Review Comment:
open https://issues.apache.org/jira/browse/KAFKA-19575 to revisit them later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
