Pankraz76 commented on code in PR #20291:
URL: https://github.com/apache/kafka/pull/20291#discussion_r2250717275
##########
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##########
@@ -638,7 +638,7 @@ object DumpLogSegments {
" Instead, the value-decoder-class option can be used if a custom RLMM
implementation is configured.")
private val shareStateOpt = parser.accepts("share-group-state-decoder",
"If set, log data will be parsed as share group state data from the " +
"__share_group_state topic.")
- private val skipRecordMetadataOpt = parser.accepts("skip-record-metadata",
"Whether to skip printing metadata for each record.")
+ private val skipRecordMetadataOpt = parser.accepts("skip-record-metadata",
"Skip metadata when printing records. This flag also skips control records.")
Review Comment:
Its better then before, thank you.
Flag is kind of clear from the context.
Now its actually like the var name itself, summarizing is down.
How you like this?
done need verb print(ing) and dont need 2 times skip when making an include
to exclude/skip.
```suggestion
private val skipRecordMetadataOpt =
parser.accepts("skip-record-metadata", "Skip record metadata print. This also
includes control records.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
