dongnuo123 commented on code in PR #20288:
URL: https://github.com/apache/kafka/pull/20288#discussion_r2250022739
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6066,7 +6075,7 @@ public CoordinatorResult<Void, CoordinatorRecord>
classicGroupJoin(
// classicGroupJoinToConsumerGroup takes the join requests to
non-empty consumer groups.
// The empty consumer groups should be converted to classic
groups in classicGroupJoinToClassicGroup.
return classicGroupJoinToConsumerGroup((ConsumerGroup) group,
context, request, responseFuture);
- } else if (group.type() == CONSUMER || group.type() == CLASSIC) {
+ } else if (group.type() == CONSUMER || group.type() == CLASSIC ||
group.type() == STREAMS && group.isEmpty()) {
return classicGroupJoinToClassicGroup(context, request,
responseFuture);
Review Comment:
Should we add a comment to state the groups accepted by
classicGroupJoinToClassicGroup here?
- existing classic group
- existing empty consumer group (will be converted to classic)
- existing empty streams group (will be converted to classic)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
