srdo commented on PR #19514: URL: https://github.com/apache/kafka/pull/19514#issuecomment-3146464381
@chia7712 I don't know how far off a new spotbugs release is, and I'd rather not keep blocking on that. I was thinking we could cut this into 3 parts, where 2 can be merged immediately: * Upgrading Spotbugs to the latest version not affected by https://github.com/spotbugs/spotbugs/pull/3311, which would break the build on Java 23. This is version 4.9.1. I've done that upgrade in https://github.com/apache/kafka/pull/20294. I think doing this makes sense, because it'll at least help flag some potential concurrency bugs that aren't caught by the current Spotbugs version. * Making CI run Java 24, but with spotbugs disabled. Since CI will run the build on 17 as well, there isn't really a strong need to run spotbugs on Java 24 right now, so skipping it for now seems better than continuing to block the Java 24 upgrade while waiting for spotbugs to do a new release. I'm going to do that in https://github.com/apache/kafka/pull/20295. * Once Spotbugs 4.9.4 releases, we can upgrade to that and let CI run spotbugs on Java 24 again. I can repurpose this PR to do that once 4.9.4 is released. I think this is better than continuing to block everything, including being able to test against Java 24, on Spotbugs putting out a new release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
