shashankhs11 opened a new pull request, #20285: URL: https://github.com/apache/kafka/pull/20285
Added 3 more tests to confirm existing behavior: - Test to try and split a single large record - Test the retry behaviour for splitting a single large record - test `hasRoomFor()` All the asserts are written to pass the tests confirming the existing buggy behaviour. I also added a test for `hasRoomFor()` - It always allows the first record no matter what the size is -- This is buggy behaviour. I think we should be checking the size but not exactly sure why we always the first record. - But after this, the `numRecords` become greater than 0, so it does not allow the subsequent records -- which is correct behaviour I suppose -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
