Pankraz76 commented on code in PR #20214:
URL: https://github.com/apache/kafka/pull/20214#discussion_r2245644605
##########
trogdor/src/main/java/org/apache/kafka/trogdor/rest/TaskRequest.java:
##########
@@ -23,14 +23,13 @@
/**
* The request to /coordinator/tasks/{taskId}
*/
-public class TaskRequest {
- private final String taskId;
-
+public record TaskRequest(String taskId) {
@JsonCreator
public TaskRequest(@JsonProperty("taskId") String taskId) {
this.taskId = taskId == null ? "" : taskId;
}
+ @Override
@JsonProperty
Review Comment:
considering `Override` kind of best practice, it should not do any harm.
Can not tell anything about `JsonProperty`, except of assuming its needed by
the business case, therefore covered by some test, or it can be
removed/challenged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
