chia7712 commented on code in PR #20243:
URL: https://github.com/apache/kafka/pull/20243#discussion_r2244422163
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -230,7 +230,9 @@ class ReplicaManager(val config: KafkaConfig,
val directoryEventHandler: DirectoryEventHandler =
DirectoryEventHandler.NOOP,
val defaultActionQueue: ActionQueue = new
DelayedActionQueue
) extends Logging {
- private val metricsGroup = new KafkaMetricsGroup(this.getClass)
+ private val metricsPackage = "kafka.server"
+ private val metricsClassName =
this.getClass.getSimpleName.replaceAll("\\$$", "")
Review Comment:
it should be replaced with constant string to avoid breaking compatibility
unexpectionally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
