chia7712 commented on code in PR #20265:
URL: https://github.com/apache/kafka/pull/20265#discussion_r2243274230
##########
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java:
##########
@@ -94,6 +94,20 @@ public class RemoteStorageMetrics {
"org.apache.kafka.storage.internals.log",
"RemoteStorageThreadPool", REMOTE_LOG_READER_TASK_QUEUE_SIZE);
public static final MetricName REMOTE_LOG_READER_AVG_IDLE_PERCENT_METRIC =
getMetricName(
"org.apache.kafka.storage.internals.log",
"RemoteStorageThreadPool", REMOTE_LOG_READER_AVG_IDLE_PERCENT);
+ /**
+ * Since `REMOTE_LOG_READER_TASK_QUEUE_SIZE_METRIC` and
`REMOTE_LOG_READER_AVG_IDLE_PERCENT_METRIC`
+ * are part of the public API, we add new metrics with the same names
under the `kafka.log.remote` group
+ * and prefix them with `BRIDGE_` to avoid conflicts with the existing
`MetricName` values.
+ * <p>
+ * The new metrics are marked as deprecated. In Kafka 5.0, we will remove
the deprecated metrics
+ * and use the `kafka.log.remote` group name as the standard going forward.
+ */
+ @Deprecated(since = "4.2")
Review Comment:
I brought this up in the mail channel
(https://lists.apache.org/thread/cpsdrwcbdyys69ozr5kfbsycrkx8zkcn)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
