mimaison commented on code in PR #19762:
URL: https://github.com/apache/kafka/pull/19762#discussion_r2240767704
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##########
@@ -340,7 +339,7 @@ class BrokerMetadataPublisher(
// recovery-from-unclean-shutdown if required.
logManager.startup(
metadataCache.getAllTopics().asScala,
- isStray = log => JLogManager.isStrayKraftReplica(brokerId,
newImage.topics(), log)
+ isStray = log => TopicsImage.isStrayReplica(newImage.topics(),
brokerId, log.topicId(), log.topicPartition().partition(), log.toString)
Review Comment:
I introduced a more generic method in `TopicsImage` called
`partitionReplicas()`, and moved the logic specific to stray partitions back to
`LogManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
