mimaison commented on code in PR #20087:
URL: https://github.com/apache/kafka/pull/20087#discussion_r2239582616


##########
storage/src/test/java/org/apache/kafka/tiered/storage/specs/ConsumableSpec.java:
##########
@@ -16,33 +16,7 @@
  */
 package org.apache.kafka.tiered.storage.specs;
 
-import java.util.Objects;
-
-public final class ConsumableSpec {
-
-    private final Long fetchOffset;
-    private final Integer expectedTotalCount;
-    private final Integer expectedFromSecondTierCount;
-
-    public ConsumableSpec(Long fetchOffset,
-                          Integer expectedTotalCount,
-                          Integer expectedFromSecondTierCount) {
-        this.fetchOffset = fetchOffset;
-        this.expectedTotalCount = expectedTotalCount;
-        this.expectedFromSecondTierCount = expectedFromSecondTierCount;
-    }
-
-    public Long getFetchOffset() {
-        return fetchOffset;
-    }
-
-    public Integer getExpectedTotalCount() {
-        return expectedTotalCount;
-    }
-
-    public Integer getExpectedFromSecondTierCount() {
-        return expectedFromSecondTierCount;
-    }
+public record ConsumableSpec(Long fetchOffset, Integer expectedTotalCount, 
Integer expectedFromSecondTierCount) {

Review Comment:
   Yep, I switched to primitive types in a bunch of classes 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to