aliehsaeedii commented on code in PR #20157:
URL: https://github.com/apache/kafka/pull/20157#discussion_r2205389398
##########
tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsGroupTest.java:
##########
@@ -405,11 +405,18 @@ public void testDeleteAllGroupsAfterVersionDowngrade()
throws Exception {
updateStreamsGroupProtocol((short) 0);
final Map<String, Throwable> result = new HashMap<>();
String output = ToolsTestUtils.grabConsoleOutput(() ->
result.putAll(service.deleteGroups()));
+ System.out.println(output);
assertTrue(output.contains("Deletion of requested streams groups
('" + appId + "') was successful."),
"The streams group could not be deleted as expected");
- assertTrue(output.contains("Retrieving internal topics is not
supported by the broker version. " +
- "Use 'kafka-topics.sh' to list and delete the group's internal
topics."));
+ assertTrue(output.contains("Retrieving internal topics is not
supported by the broker version. "));
+ assertTrue(output.contains("Use 'kafka-topics.sh' to delete the
group's internal topics."));
+ // Validate the list of internal topics in error message
+ assertTrue(output.contains("Internal topics:"));
+ assertTrue(output.contains("aggregated_value-changelog"));
Review Comment:
@lucliu1108 Perfect
Btw, could we add the appId/groupId add the beginning? Sth that shows the
internal topic names name pattern? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
