frankvicky commented on code in PR #20068:
URL: https://github.com/apache/kafka/pull/20068#discussion_r2187343781
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2873,23 +2873,41 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
/** Changes the <i>preferred</i> leader without changing the
<i>current</i> leader. */
def changePreferredLeader(newAssignment: Seq[Int]): Unit = {
val preferred = newAssignment.head
- val prior1 =
brokers.head.metadataCache.getPartitionLeaderEndpoint(partition1.topic,
partition1.partition(), listenerName).get.id()
- val prior2 =
brokers.head.metadataCache.getPartitionLeaderEndpoint(partition2.topic,
partition2.partition(), listenerName).get.id()
-
- var m = Map.empty[TopicPartition, Optional[NewPartitionReassignment]]
- if (prior1 != preferred)
- m += partition1 -> Optional.of(new
NewPartitionReassignment(newAssignment.map(Int.box).asJava))
- if (prior2 != preferred)
- m += partition2 -> Optional.of(new
NewPartitionReassignment(newAssignment.map(Int.box).asJava))
- client.alterPartitionReassignments(m.asJava).all().get()
+ var prior1 =
brokers.head.metadataCache.getPartitionLeaderEndpoint(partition1.topic,
partition1.partition(), listenerName).get.id()
+ var prior2 =
brokers.head.metadataCache.getPartitionLeaderEndpoint(partition2.topic,
partition2.partition(), listenerName).get.id()
TestUtils.waitUntilTrue(
- () => preferredLeader(partition1) == preferred &&
preferredLeader(partition2) == preferred,
+ () => {
+ prior1 =
brokers.head.metadataCache.getPartitionLeaderEndpoint(partition1.topic,
partition1.partition(), listenerName).get.id()
+ prior2 =
brokers.head.metadataCache.getPartitionLeaderEndpoint(partition2.topic,
partition2.partition(), listenerName).get.id()
+ var m = Map.empty[TopicPartition, Optional[NewPartitionReassignment]]
Review Comment:
Could you give this variable a meaningful name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
