[ 
https://issues.apache.org/jira/browse/KAFKA-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767760#comment-16767760
 ] 

Matthias J. Sax commented on KAFKA-7930:
----------------------------------------

Thanks for creating this ticket. I agree that naming assumptions could be 
optional. However, why would you want to make topic deletion optional? That 
whole purpose of the tool is to delete internal topics. For the last point: I 
think it kinda makes sense, however why would you have an input topic with name 
patter `<application.id>-someName-repartition` or 
`<application.id>-someName-changelog` ?
 
{quote}Faced this, when was trying to reset applications with GlobalKTable 
topics named as *-changelog. Such topics sometimes are not desirable for 
deletion.
{quote}
If it's does not have `<application.id>-` prefix it won't be deleted. Can you 
elaborate?

> StreamsResetter makes "changelog" topic naming assumptions
> ----------------------------------------------------------
>
>                 Key: KAFKA-7930
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7930
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, tools
>    Affects Versions: 2.1.0
>            Reporter: Murad M
>            Priority: Major
>              Labels: features, patch-available, usability
>
> StreamsResetter deletes the topics considered internal. Currently it just 
> checks the naming as per 
> [code|https://github.com/apache/kafka/blob/1aae604861068bb7337d4972c9dcc0c0a99c374d/core/src/main/scala/kafka/tools/StreamsResetter.java#L660].
>  If assumption is wrong (either topic prefix or suffix), tool becomes useless 
> if aware even dangerous if not. Probably better either:
>  * naming assumption should be optional and supply internal topics with 
> argument (--internal-topics)
>  * deletion could be optional (--no-delete-internal)
>  * ignore topics which are included in list of --input-topics
> Faced this, when was trying to reset applications with GlobalKTable topics 
> named as *-changelog. Such topics sometimes are not desirable for deletion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to