DL1231 commented on code in PR #19914:
URL: https://github.com/apache/kafka/pull/19914#discussion_r2132415250
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##########
@@ -99,7 +99,7 @@ public void signalClose() {
*/
@Override
public NetworkClientDelegate.PollResult poll(final long currentTimeMs) {
- if (closing || this.coordinator != null)
+ if (this.coordinator != null)
Review Comment:
Thanks for the PR, left a comment.
Should we add an IT for this scenario: when closing the consumer,
commitAsync, and verify that the consumer can shut down properly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
