DL1231 commented on code in PR #19904:
URL: https://github.com/apache/kafka/pull/19904#discussion_r2127826516
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8537,6 +8659,32 @@ static String consumerGroupSyncKey(String groupId,
String memberId) {
return "sync-" + groupId + "-" + memberId;
}
+ /**
+ * Generate a regex refresh key for the timer.
+ *
+ * Package private for testing.
+ *
+ * @param groupId The group id.
+ *
Review Comment:
nit: extra blank
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -204,6 +204,11 @@ public class GroupCoordinatorConfig {
ConsumerGroupMigrationPolicy.DOWNGRADE + ": only downgrade from
consumer group to classic group is enabled, " +
ConsumerGroupMigrationPolicy.DISABLED + ": neither upgrade nor
downgrade is enabled.";
+ public static final String CONSUMER_GROUP_REGEX_REFRESH_INTERVAL_CONFIG =
"group.consumer.regex.refresh.interval.ms";
+ public static final String CONSUMER_GROUP_REGEX_REFRESH_INTERVAL_DOC =
"The interval at which the group coordinator will atomatically" +
Review Comment:
What is the 'atomatically' mean?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8537,6 +8659,32 @@ static String consumerGroupSyncKey(String groupId,
String memberId) {
return "sync-" + groupId + "-" + memberId;
}
+ /**
+ * Generate a regex refresh key for the timer.
+ *
+ * Package private for testing.
+ *
+ * @param groupId The group id.
+ *
+ * @return the regex timeout refresh key.
+ */
+ static String regexTimeoutRefreshKeyForTimer(String groupId) {
+ return "regex-timeout-refresh-for-timer-" + groupId;
+ }
+
+ /**
+ * Generate a regex refresh key for the executor.
+ *
+ * Package private for testing.
+ *
+ * @param groupId The group id.
+ *
Review Comment:
nit: extra blank
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -20542,6 +20553,112 @@ barTopicName, computeTopicHash(barTopicName,
metadataImage)
);
}
+ @Test
Review Comment:
Should we add IT for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
