rreddy-22 commented on code in PR #19902:
URL: https://github.com/apache/kafka/pull/19902#discussion_r2127251654
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerAppendInfo.java:
##########
@@ -110,6 +110,13 @@ private void checkProducerEpoch(short producerEpoch, long
offset) {
}
private void checkSequence(short producerEpoch, int appendFirstSeq, long
offset) {
+ // For transactions v2 idempotent producers, reject non-zero sequences
when there is no producer ID state
+ if (verificationStateEntry != null &&
verificationStateEntry.supportsEpochBump() &&
+ appendFirstSeq != 0 && currentEntry.isEmpty()) {
Review Comment:
Any empty state is rejected, right? Or do we only want to reject the empty
state with no producer epoch? Might be missing some context so let me know what
the expected behavior is!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
