apoorvmittal10 commented on code in PR #19863:
URL: https://github.com/apache/kafka/pull/19863#discussion_r2120969645
##########
docs/api.html:
##########
@@ -48,6 +48,9 @@ <h3 class="anchor-heading"><a id="consumerapi"
class="anchor-link"></a><a href="
Examples showing how to use the consumer are given in the
<a
href="/{{version}}/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaConsumer.html"
title="Kafka {{dotVersion}} Javadoc">javadocs</a>.
<p>
+ Examples showing how to use the share consumer are given in the
+ <a
href="/{{version}}/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaShareConsumer.html"
title="Kafka {{dotVersion}} Javadoc">javadocs</a>.
+ <p>
Review Comment:
Just asking your thoughts: Should it be a separate `Share Consumer API`?
##########
docs/upgrade.html:
##########
@@ -15,15 +15,18 @@
limitations under the License.
-->
-<script><!--#include virtual="js/templateData.js" --></script>
-
-<script id="upgrade-template" type="text/x-handlebars-template">
-
<h4><a id="upgrade_4_1_0" href="#upgrade_4_1_0">Upgrading to 4.1.0</a></h4>
<h5><a id="upgrade_4_1_0" href="#upgrade_4_1_0">Upgrading Servers to 4.1.0
from any version 3.3.x through 4.0.x</a></h5>
<h6><a id="upgrade_410_notable" href="#upgrade_410_notable">Notable
changes in 4.1.0</a></h6>
<ul>
+ <li>
+ Apache Kafka 4.1 ships with a preview of Queues for Kafka (<a
href="https://cwiki.apache.org/confluence/x/4hA0Dw";>KIP-932</a>). This feature
introduces a new kind of group called
+ share groups, as an alternative to consumer groups. The
consumers in a share group cooperatively consume records from topics, without
assigning each partition to just one consumer.
+ Share groups also introduce per-record acknowledgement and
counting of delivery attempts. Share groups are well suited to use cases in
which the records are being processed
+ one at a time, rather than as part of an ordered stream. To
enable share groups, use the <code>kafka-features.sh</code> tool to upgrade to
<code>share.version=1</code>.
+ For more information, please read the <a
href="https://cwiki.apache.org/confluence/display/KAFKA/Queues+for+Kafka+%28KIP-932%29+-+Preview+Release+Notes";>
release notes</a>.
Review Comment:
```suggestion
For more information, please read the <a
href="https://cwiki.apache.org/confluence/x/CIq3FQ";> release notes</a>.
```
##########
docs/upgrade.html:
##########
@@ -15,15 +15,18 @@
limitations under the License.
-->
-<script><!--#include virtual="js/templateData.js" --></script>
-
-<script id="upgrade-template" type="text/x-handlebars-template">
Review Comment:
For my understanding: why this has been removed?
##########
docs/configuration.html:
##########
@@ -205,56 +205,61 @@ <h3 class="anchor-heading"><a id="topicconfigs"
class="anchor-link"></a><a href=
<!--#include virtual="generated/topic_config.html" -->
- <h3 class="anchor-heading"><a id="producerconfigs"
class="anchor-link"></a><a href="#producerconfigs">3.3 Producer Configs</a></h3>
+ <h3 class="anchor-heading"><a id="groupconfigs" class="anchor-link"></a><a
href="#groupconfigs">3.3 Group Configs</a></h3>
+
+ Below is the configuration of the groups:
+ <!--#include virtual="generated/group_config.html" -->
Review Comment:
This also lists streams config, is it intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
