YutaLin commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2111733517
########## server/src/main/java/org/apache/kafka/server/ClientSensors.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server; + +import org.apache.kafka.common.metrics.Sensor; + +import java.util.Map; +import java.util.Objects; + +/** + * Represents the sensors aggregated per client + * metricTags Quota metric tags for the client + * quotaSensor @Sensor that tracks the quota + * throttleTimeSensor @Sensor that tracks the throttle time + */ +public final class ClientSensors { + private final Map<String, String> metricTags; + private final Sensor quotaSensor; + private final Sensor throttleTimeSensor; + + public ClientSensors(Map<String, String> metricTags, + Sensor quotaSensor, + Sensor throttleTimeSensor) { + this.metricTags = Map.copyOf(metricTags); // Defensive immutable copy + this.quotaSensor = Objects.requireNonNull(quotaSensor); + this.throttleTimeSensor = Objects.requireNonNull(throttleTimeSensor); + } + + // Getters (equivalent to case class field access) + public Map<String, String> metricTags() { + return metricTags; + } + + public Sensor quotaSensor() { + return quotaSensor; + } + + public Sensor throttleTimeSensor() { + return throttleTimeSensor; + } + + // equals, hashCode, toString (equivalent to case class generated methods) + @Override + public boolean equals(Object obj) { + if (this == obj) return true; + if (obj == null || getClass() != obj.getClass()) return false; + ClientSensors that = (ClientSensors) obj; + return Objects.equals(metricTags, that.metricTags) && + Objects.equals(quotaSensor, that.quotaSensor) && + Objects.equals(throttleTimeSensor, that.throttleTimeSensor); + } + + @Override + public int hashCode() { + return Objects.hash(metricTags, quotaSensor, throttleTimeSensor); + } + + @Override + public String toString() { + return "ClientSensors{" + + "metricTags=" + metricTags + + ", quotaSensor=" + quotaSensor + + ", throttleTimeSensor=" + throttleTimeSensor + + '}'; + } Review Comment: Oh, I moved this from a Scala case class, so I added that comment. Let me remove it to avoid confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
