lianetm commented on code in PR #19818:
URL: https://github.com/apache/kafka/pull/19818#discussion_r2111587706
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java:
##########
@@ -998,16 +1005,43 @@ public void
testIgnoreHeartbeatResponseWhenNotInGroup(MemberState state) {
assertEquals(state, membershipManager.state());
verify(responseData, never()).memberId();
- verify(responseData, never()).memberEpoch();
+ // In unsubscribed, we check if we received a leave group response, so
we do verify member epoch.
+ if (state != MemberState.UNSUBSCRIBED) {
+ verify(responseData, never()).memberEpoch();
+ }
verify(responseData, never()).assignment();
}
@Test
- public void testLeaveGroupWhenStateIsReconciling() {
- ConsumerMembershipManager membershipManager =
mockJoinAndReceiveAssignment(false);
- assertEquals(MemberState.RECONCILING, membershipManager.state());
+ public void testIgnoreLeaveResponseWhenNotLeavingGroup() {
+ ConsumerMembershipManager membershipManager =
createMemberInStableState();
-
testLeaveGroupReleasesAssignmentAndResetsEpochToSendLeaveGroup(membershipManager);
+ CompletableFuture<Void> leaveResult = membershipManager.leaveGroup();
+
+ // Send leave request, transitioning to UNSUBSCRIBED state
+ membershipManager.onHeartbeatRequestGenerated();
+ assertEquals(MemberState.UNSUBSCRIBED, membershipManager.state());
+
+ // Receive a previous heartbeat response, which should be ignored
+ membershipManager.onHeartbeatSuccess(new
ConsumerGroupHeartbeatResponse(
+ new ConsumerGroupHeartbeatResponseData()
+ .setErrorCode(Errors.NONE.code())
+ .setMemberId(membershipManager.memberId())
+ .setMemberEpoch(MEMBER_EPOCH)
+ ));
+ assertFalse(leaveResult.isDone());
Review Comment:
the response being ignored is a non-leave response with MEMBER_EPOCH=1, but
the test name "IgnoreLeaveResponse" doesn't align right? Clarifying because we
could also want to test that a leave response is ignored (if the member already
transitioned to JOINING when the leave resp is received)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
